Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated syntax and fixed possible performance issues #4276

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jhonDoe15
Copy link

@jhonDoe15 jhonDoe15 commented Oct 5, 2023

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • My changes generate no new warnings (e.g. Sonar is happy)
  • New and existing unit tests pass locally with my changes

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
image

@jhonDoe15 jhonDoe15 requested a review from a team as a code owner October 5, 2023 19:22
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there jhonDoe15! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@jhonDoe15
Copy link
Author

looks like the E2E failing is cause of a config issue of the E2E tests rather than the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant