solved issue with loader

[dwikov]

• Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Removed checking for isSubmitting and add reset for isTopicCreated.
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

• No need to
• Manually(please, describe, when necessary)
• Unit checks
• Integration checks
• Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
• My changes generate no new warnings(e.g. Sonar is happy)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

Check out Contributing and Code of Conduct

[workshur]

I see that resetUploadedState dispatches createTopicAction.failure. Can we create separate action to reset state instead of using failure?

[dwikov]

I see that resetUploadedState dispatches createTopicAction.failure. Can we create separate action to reset state instead of using failure?

Yeah that's why I didn't think it was a good idea to do it like this. We can create one more called createTopicAction.cancel and make it responsible for resetting the state.

[workshur]

@dwikov I think we can clear state right here, without adding new actions

kafka-ui/kafka-ui-react-app/src/redux/actions/thunks/topics.ts

Lines 249 to 258 in b60ff8a

	const newState = {
	...state,
	byName: {
	...state.byName,
	[topic.name]: {
	...topic,
	},
	},
	allNames: [...state.allNames, topic.name],
	};

[dwikov]

@dwikov I think we can clear state right here, without adding new actions

kafka-ui/kafka-ui-react-app/src/redux/actions/thunks/topics.ts

Lines 249 to 258 in b60ff8a

	const newState = {
	...state,
	byName: {
	...state.byName,
	[topic.name]: {
	...topic,
	},
	},
	allNames: [...state.allNames, topic.name],
	};

We can clear the state of topics here, the issue is with the loader state. As far as I understand, the reducer of the loader changes the state of the loader according to the action called, success fail or fetching.

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

33.3% Coverage
0.0% Duplication

[workshur]

We're on the wrong track. Loader reducer used only for async actions