Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AddGovPropFlagsToCmd and ReadGovPropFlags. #434

Merged
merged 6 commits into from
Jan 23, 2023

Conversation

SpicyLemon
Copy link

Description

This PR:

  1. Makes the FlagMetadata variable public.
  2. Creates an AddGovPropFlagsToCmd func that adds FlagDeposit, and FlagMetadata to a cobra command.
  3. Creates a ReadGovPropFlags func that creates a MsgSubmitProposal pre-populated with provided flag values and proposer (from address).

It's similar to cosmos#14718 except doesn't have the FlagTitle, and FlagSummary yet since that's not yet in our fork.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@SpicyLemon SpicyLemon changed the title Prov/dwedul/gov flags Create AddGovPropFlagsToCmd and ReadGovPropFlags. Jan 20, 2023
Copy link

@derekadams derekadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpicyLemon SpicyLemon merged commit 8130f37 into main-pio Jan 23, 2023
@SpicyLemon SpicyLemon deleted the prov/dwedul/gov-flags branch February 28, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants