Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nav data to hash history table #555

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Oct 3, 2024

Description

This PR adds data ingestion from both Flow (on chain Nav values) and Osmosis data sources for historical hash prices, which is displayed in the 14-Day Hash Price History section of the explorer landing page.

Additional Updates:

It refactors the lastKnownPriceForDate query to limit the number of rows returned from postgres instead of doing FirstOrNull on kotlin side.

The percentage change calculation has been updated to return values at a scale to one decimal in all cases. Before the change, the percentage change calculation would use the scale of the BigDecimal that was passed into the function as the divisor (orig). This meant that the result could have varying decimal places, depending on the scale of the input values. Now, the calculation always returns a value with a scale of 1 decimal place.

Tests were added for changes.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 self-assigned this Oct 3, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review October 3, 2024 21:31
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner October 3, 2024 21:31
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) October 3, 2024 21:53
@nullpointer0x00 nullpointer0x00 merged commit 7f16bcb into main Oct 3, 2024
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/hash-price-history-use-multi-source-fetchers branch October 3, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants