Set asset pricing data column to null on updates from flow grpc #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scirner22
approved these changes
Oct 18, 2024
| @@ -219,7 +219,7 @@ object AssetPricingTable : IdTable<Int>(name = "asset_pricing") { | |||
| val pricing = decimal("pricing", 100, 50) | |||
| val pricingDenom = varchar("pricing_denom", 256) | |||
| val lastUpdated = datetime("last_updated") | |||
| val data = jsonb<AssetPricingTable, AssetPricing>("data", OBJECT_MAPPER) | |||
| val data = jsonb<AssetPricingTable, AssetPricing>("data", OBJECT_MAPPER).nullable() | |||
There was a problem hiding this comment.
Just verifying since I don't see a DB migration here, the current column in the db is nullable?
There was a problem hiding this comment.
Yes, it is. I just needed a way to set it on the kotlin side to null for updates.
I will be removing this column in the future anyway: #563
It was saving the json that was returned from figure pricing, which didn't have any extra information that wasn't already being saved as a column.
nullpointer0x00
deleted the
nullpointer0x00/set-data-column-to-null-asset-pricing
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the asset pricing update logic by ensuring the
datacolumn is set tonullon update or insert. Previously, thedatacolumn contained the json response from the figure pricing service, which is no longer necessary since data now comes from the Flow API. By nullifying thedatacolumn, we remove this outdate content.This column will be removed completely in the future: #563
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes