Add v1beta2 version of validation protos with metadata for results #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpatel-figure
force-pushed
the
ravipatel/make-validation-protos-more-meta
branch
from
2f154ab to
589ad02
Compare
rpatel-figure
added
docs
rpatel-figure
requested review from
vwagner and
dkneisly-figure
as code owners
rpatel-figure
force-pushed
the
ravipatel/make-validation-protos-more-meta
branch
3 times, most recently
from
6e9d235 to
1544946
Compare
rpatel-figure
force-pushed
the
ravipatel/make-validation-protos-more-meta
branch
2 times, most recently
from
d5b5399 to
a36ecb9
Compare
rpatel-figure
force-pushed
the
ravipatel/make-validation-protos-more-meta
branch
from
a36ecb9 to
3a69934
Compare
dkneisly-figure
approved these changes
Feb 16, 2023
rpatel-figure
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Despite our best efforts to keep models generic and extensible, it's difficult to define schema for loan validation usecases which suit everyone's needs. This PR redefines the existing loan validation protobufs under a new package,
v1beta2, which instead use a simple metadata schema for validation results, so that results can simply be a pointer to an entry in an encrypted object store. It still redefines theValidationResultsprotobuf verbatim, to act as a recommended schema for whatValidationResultsMetadatashould point to.Changes
tech.figure.validation.v1beta2which replaces usage ofValidationResultsfromv1beta1in wrapper protos into a simple metadata pointer objectValidationResultsMetadatadocs/util.mdin attempt to address wonky behavior when clicking said linksutil.md