Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sim tests so that they pass. #754

Closed
4 tasks
dwedul-figure opened this issue Mar 24, 2022 · 2 comments
Closed
4 tasks

Fix sim tests so that they pass. #754

dwedul-figure opened this issue Mar 24, 2022 · 2 comments
Assignees
Labels
bug Something isn't working simulation Issues related to simulation testing
Milestone

Comments

@dwedul-figure
Copy link
Contributor

dwedul-figure commented Mar 24, 2022

Summary of Bug

At least a couple of the sim tests fail due to insufficient funds. These failures might end up masking other, more serious failures.

Version

main

Steps to Reproduce

The following commands result in the following errors:

  • make test-sim-after-import -> "panic: expected validator, not found"
  • make test-sim-nondeterminism-state-listening-file -> "panic: stored minter should not have been nil"
  • make test-sim-nondeterminism-state-listening-trace -> "panic: stored minter should not have been nil"
  • make test-sim-nondeterminism-state-listening-kafka -> "panic: stored minter should not have been nil"

Once fixed, the .github/workflows/sims.yml file should be updated too, so that those tests run.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dwedul-figure dwedul-figure added bug Something isn't working simulation Issues related to simulation testing labels Mar 24, 2022
@channa-figure channa-figure self-assigned this Apr 19, 2022
@dwedul-figure
Copy link
Contributor Author

dwedul-figure commented May 14, 2022

After some more digging, I found that the following sims are broken:

  • test-sim-after-import: "panic: expected validator, not found"
  • test-sim-nondeterminism-state-listening-file: "panic: stored minter should not have been nil"
  • test-sim-nondeterminism-state-listening-trace: "panic: stored minter should not have been nil"
  • test-sim-nondeterminism-state-listening-kafka: "panic: stored minter should not have been nil"
    I've updated the issue to reflect this.

@iramiller iramiller added this to the v1.13.0 milestone Sep 21, 2022
@SpicyLemon
Copy link
Contributor

No longer an issue. the state listening ones were removed and the after-import sim has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working simulation Issues related to simulation testing
Projects
Development

No branches or pull requests

4 participants