Add the removed sims back into the github actions. #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkflow. That way, changes to that file will kick off the sims too.
…stead of test field.
…allow definition of the genesis file for applicable tests (instead of just using a hard-coded path off the HOME directory).
…s. Also have it fail early if zookeeper or broker can't be started.
…trigger sim runs if changed.
…the state-listening tests to see how they do.
…controlled only by the list given to diff.
…lt it to the one that already exists in our repo.
…runsim db backend.
…o exit with the code of the test instead of the stopping of kafka.
…ded for kafka mac test, but if it doesn't hurt the ubuntu test, I'll just leave it.
…ims get skipped for now.
derekadams
previously approved these changes
May 11, 2022
…he after-import test back in but have it skipped.
… And there's no way to manually mark a job as skipped. So go back to just not running it.
Codecov Report
@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 56.19% 56.13% -0.06%
==========================================
Files 179 179
Lines 21850 21819 -31
==========================================
- Hits 12278 12248 -30
+ Misses 8652 8651 -1
Partials 920 920
|
…ke target to explain why it's different from the others.
dwedul-figure
requested review from
iramiller,
channa-figure,
arnabmitra and
egaxhaj
as code owners
egaxhaj
approved these changes
May 16, 2022
iramiller
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
state-listeningsims. These currently panic at block 2 though, so I have the job disabled for now.test-sim-nondeterminism-state-listening-kafkamake target to exit with the same code that the tests exit with. Also fix the docker-compose.yml default location and have it definable through theSIM_DOCKER_COMPOSE_YMLenvironment variable.This PR is related to #754. This one only adds some of the sims back in, but doesn't fix any of the broken sims:
after-import', all of thestate-listening` ones.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes