Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config update command #1233

Merged
merged 14 commits into from
Nov 21, 2022
Merged

Config update command #1233

merged 14 commits into from
Nov 21, 2022

Commits on Nov 18, 2022

  1. Configuration menu
    Copy the full SHA
    673792a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bc4924 View commit details
    Browse the repository at this point in the history
  3. [1216]: It turns out that the unpack command is exactly what's needed…

    … for update. So Just add that as an alias, and a little extra note in the Long entry for it.
    SpicyLemon committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ec0744c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    06c450a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2fc417 View commit details
    Browse the repository at this point in the history
  6. [1216]: When loading a FieldValueMap into viper, Instead of loading s…

    …ectioned keys into viper as the full thing, use a section entry with each sub-key in that. That's how it gets loaded when being read from a file. And since we now want to load the defaults (via FieldValueMap) then, if the file exists, read/load it, we ended up with things in two places. It was either do this or change all the file loading to manually read the file, create FieldValueMaps from it and give that to viper.
    SpicyLemon committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    8361b00 View commit details
    Browse the repository at this point in the history
  7. [1216]: Create a DefaultAppConfig that applies our default min-gas-pr…

    …ices to the object and use that instead of serverconfig.DefaultConfig where needed. The result is that all the config stuff no longer thinks the default min-gas-prices is an empty string. Plus, if the app.toml doesn't exist, viper ends up with our default for min-gas-prices too. Also, use the new AsConfigMap for creating the config map in addFieldMapToViper.
    SpicyLemon committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    bce463f View commit details
    Browse the repository at this point in the history
  8. [1216]: Update the config tests (slightly) to account for the default…

    … min-gas-prices being what we've defined and add a test to the packed config that makes sure that default is being applied.
    SpicyLemon committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    931e472 View commit details
    Browse the repository at this point in the history
  9. [1216]: In the manager tests, switch to DefaultAppConfig as needed an…

    …d add a canary for the global-labels special handling.
    SpicyLemon committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ec6ddc6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e4b457c View commit details
    Browse the repository at this point in the history
  11. [1216]: Undo a small change to one of the tests that isn't actually n…

    …eeded (was just for troubleshooting).
    SpicyLemon committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    d65be24 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    641437f View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Configuration menu
    Copy the full SHA
    c793139 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    222d89c View commit details
    Browse the repository at this point in the history