Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esqueleto.cabal: Bump upper dependency limit for base #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

esqueleto.cabal: Bump upper dependency limit for base #135

wants to merge 1 commit into from

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Apr 14, 2016

Ghc 8.0 ships with base 4.9.

@erikd
Copy link
Contributor Author

erikd commented Apr 14, 2016 •
edited
Loading

This fix is necessary for ghc-8.0 support, but not sufficient to make it compile against the current git HEAD of persistent which has some siginificant changes to data types since the last release.

@erikd
Copy link
Contributor Author

erikd commented Apr 19, 2016 •
edited
Loading

For yesod-persistent @snoyberg has decided to use CPP to make it work with both persistent < 2.5 and persistent == 2.5. For example yesodweb/yesod@d99de61 .

I'm happy to do the fixes, but I'd like you to make the decision on whether you to use CPP to support a similar range of persistent versions to yesod-persistent or whether you just want to support persistent == 2.5.

This was referenced Apr 20, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erikd