-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws_regions): Get enabled regions #3095
Merged
MrCloudSec
merged 11 commits into
master
from
PRWLR-2809-suggestions-check-for-enabled-regions-3089
Dec 11, 2023
Merged
fix(aws_regions): Get enabled regions #3095
MrCloudSec
merged 11 commits into
master
from
PRWLR-2809-suggestions-check-for-enabled-regions-3089
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70fde82
to
dda8c02
Compare
…2809-suggestions-check-for-enabled-regions-3089
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3095 +/- ##
==========================================
- Coverage 86.16% 85.96% -0.21%
==========================================
Files 562 563 +1
Lines 18290 18084 -206
==========================================
- Hits 15760 15546 -214
- Misses 2530 2538 +8 ☔ View full report in Codecov by Sentry. |
MrCloudSec
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR !! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3089 Thanks for the idea @Fennerr !
RIght now Prowler audits all the regions by a given service not taking into account if the region is enabled within AWS.
Description
For each AWS service supported in Prowler check if the regions, where the service is available, are enabled in the audited AWS account.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.