Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws_regions): Get enabled regions #3095

Merged

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Dec 4, 2023

Context

Fixes #3089 Thanks for the idea @Fennerr !

RIght now Prowler audits all the regions by a given service not taking into account if the region is enabled within AWS.

Description

For each AWS service supported in Prowler check if the regions, where the service is available, are enabled in the audited AWS account.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added no-merge Please, DO NOT MERGE this PR. provider/aws Issues/PRs related with the AWS provider labels Dec 4, 2023
@jfagoagas jfagoagas self-assigned this Dec 4, 2023
@jfagoagas jfagoagas requested a review from a team December 4, 2023 09:34
@jfagoagas jfagoagas force-pushed the PRWLR-2809-suggestions-check-for-enabled-regions-3089 branch from 70fde82 to dda8c02 Compare December 4, 2023 16:33
@jfagoagas jfagoagas removed no-merge Please, DO NOT MERGE this PR. testing-pending labels Dec 4, 2023
…2809-suggestions-check-for-enabled-regions-3089
@jfagoagas jfagoagas added the no-merge Please, DO NOT MERGE this PR. label Dec 4, 2023
@jfagoagas jfagoagas removed the no-merge Please, DO NOT MERGE this PR. label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1be52fa) 86.16% compared to head (90f7cf7) 85.96%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3095      +/-   ##
==========================================
- Coverage   86.16%   85.96%   -0.21%     
==========================================
  Files         562      563       +1     
  Lines       18290    18084     -206     
==========================================
- Hits        15760    15546     -214     
- Misses       2530     2538       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR !! 🚀

@MrCloudSec MrCloudSec merged commit c9cb977 into master Dec 11, 2023
@MrCloudSec MrCloudSec deleted the PRWLR-2809-suggestions-check-for-enabled-regions-3089 branch December 11, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions: Check for enabled regions
2 participants