Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcp): improve logging messages #3185

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(gcp): improve logging messages #3185

merged 1 commit into from
Dec 12, 2023

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Dec 12, 2023

Context

If an user does not have the cloudresourcemanager API enabled, it will throw an ERROR log and abort the execution of Prowler and he may not see it.

Description

Adding a print showing that the cloudresourcemanager API is not enabled and also solves a typo in the other print.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested a review from a team December 12, 2023 11:27
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7fcff54) 86.00% compared to head (543f975) 86.00%.
Report is 1 commits behind head on master.

Files Patch % Lines
prowler/providers/gcp/gcp_provider.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
- Coverage   86.00%   86.00%   -0.01%     
==========================================
  Files         564      564              
  Lines       18156    18158       +2     
==========================================
+ Hits        15615    15616       +1     
- Misses       2541     2542       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit 3c3dfb3 into master Dec 12, 2023
@MrCloudSec MrCloudSec deleted the gcp-api-error branch December 12, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants