Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticache): handle empty cluster subnets #4192

Conversation

MrCloudSec
Copy link
Member

Description

Handle Elasticache clusters when they don't have any subnet.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team June 5, 2024 16:04
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (f3c6720) to head (c7a4f6b).
Report is 417 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4192      +/-   ##
==========================================
- Coverage   86.76%   86.69%   -0.08%     
==========================================
  Files         817      817              
  Lines       25599    25599              
==========================================
- Hits        22211    22193      -18     
- Misses       3388     3406      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@MrCloudSec MrCloudSec merged commit 7b43b3d into master Jun 6, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-3867-handle-elasticache-cluster-uses-public-subnet-type-error-24-none-type-object-is-not-iterable branch June 6, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants