Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status): Recover status filtering #4572

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Jul 30, 2024

Context

Fixes #4571

Description

Recover the status filtering for findings.

TODO

  • Add tests to prevent this from happening again
  • Think about the current logic
  • Add a clear explanation of this logic to the documentation

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested review from a team as code owners July 30, 2024 12:52
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (e3f6684) to head (b0e54c5).
Report is 525 commits behind head on master.

Files with missing lines Patch % Lines
...ler/providers/aws/lib/security_hub/security_hub.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4572      +/-   ##
==========================================
+ Coverage   88.93%   88.94%   +0.01%     
==========================================
  Files         910      910              
  Lines       27661    27691      +30     
==========================================
+ Hits        24600    24631      +31     
+ Misses       3061     3060       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas added no-merge Please, DO NOT MERGE this PR. testing-pending labels Jul 30, 2024
@sergargar sergargar removed no-merge Please, DO NOT MERGE this PR. testing-pending labels Jul 30, 2024
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jul 30, 2024
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@jfagoagas
Copy link
Member Author

@sergargar could you please review the usage of the status is some other parts of the code like in Security Hub? Maybe we can do some cleanup with your changes here.

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@github-actions github-actions bot added the integration/security-hub Issues/PRs related with the AWS Security Hub integration label Jul 31, 2024
sergargar
sergargar previously approved these changes Jul 31, 2024
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@sergargar sergargar self-requested a review July 31, 2024 13:49
@sergargar sergargar merged commit 8461257 into master Jul 31, 2024
11 of 12 checks passed
@sergargar sergargar deleted the PRWLR-4371-filter-findings-by-status-does-not-have-any-effect-on-output-files-4571 branch July 31, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation integration/security-hub Issues/PRs related with the AWS Security Hub integration provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter findings by status does not have any effect on output files
2 participants