Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): use threads for describing task definitions #4733

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Aug 13, 2024

Description

Use threading for __describe_task_definition__ function to improve the performance of ECS service.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners August 13, 2024 19:56
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Aug 13, 2024
@MrCloudSec MrCloudSec added backport-to-v4.3 and removed provider/aws Issues/PRs related with the AWS provider labels Aug 13, 2024
Copy link
Member

@drewkerrigan drewkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to speed this up, thanks @sergargar !

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (eed8f30) to head (146466e).
Report is 232 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #4733      +/-   ##
==========================================
- Coverage   86.86%   86.86%   -0.01%     
==========================================
  Files         714      714              
  Lines       22494    22493       -1     
==========================================
- Hits        19539    19538       -1     
  Misses       2955     2955              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snaow snaow merged commit 8b2659b into v3 Aug 13, 2024
11 checks passed
@snaow snaow deleted the PRWLR-4581-improve-ecs-task-definitions-no-environment-secrets-check-to-speed-it-up branch August 13, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants