Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(elasticache): add check
elasticache_redis_cluster_auth_enabled
#4830feat(elasticache): add check
elasticache_redis_cluster_auth_enabled
#4830Changes from 19 commits
a328b02
d1dd13a
e8f0a3d
2a1fb68
412f688
63efb1c
aad2ec8
0f7b95e
a0b289e
6b01746
c08ef95
a7b8000
48f6f6d
79603de
4faddef
81ebc75
7bcaee8
a18b7ad
003c82a
66aeb8f
25958b6
dd3363a
9dc0b9e
73ec237
3fb54a8
42b2cdd
97440d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, can you show in the status extended the member clusters that are not compliant (if any).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can member cluster have different versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, leave it as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm concerned, every node must have the exact same version inside a replication group.
Check warning on line 104 in prowler/providers/aws/services/elasticache/elasticache_service.py
Codecov / codecov/patch
prowler/providers/aws/services/elasticache/elasticache_service.py#L104
Check warning on line 136 in prowler/providers/aws/services/elasticache/elasticache_service.py
Codecov / codecov/patch
prowler/providers/aws/services/elasticache/elasticache_service.py#L135-L136