Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws): Remove token from log line #4904

Conversation

jfagoagas
Copy link
Member

Description

We need to remove a log line in the AWS Provider that shows boto3 credentials, is not something critical because they are dynamic and short-lived, it lasts just one hour.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the v3 Everything related to Prowler 3.0 label Aug 30, 2024
@jfagoagas jfagoagas requested review from a team as code owners August 30, 2024 08:47
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Aug 30, 2024
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (15b8801) to head (6f84387).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
prowler/providers/aws/aws_provider.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #4904      +/-   ##
==========================================
+ Coverage   86.93%   86.94%   +0.01%     
==========================================
  Files         714      714              
  Lines       22504    22503       -1     
==========================================
+ Hits        19564    19566       +2     
+ Misses       2940     2937       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas merged commit 9f49963 into v3 Aug 30, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-4739-remove-aws-provider-log-line-that-shows-boto-3-credentials-dynamic-and-short-lived-v3 branch August 30, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider v3 Everything related to Prowler 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants