-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(execute_check): refactor execute method #4975
Merged
pedrooot
merged 9 commits into
master
from
PRWLR-4681-execute-should-run-the-checks-execute-and-nothing-more
Sep 25, 2024
Merged
refactor(execute_check): refactor execute method #4975
pedrooot
merged 9 commits into
master
from
PRWLR-4681-execute-should-run-the-checks-execute-and-nothing-more
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrooot
force-pushed
the
PRWLR-4681-execute-should-run-the-checks-execute-and-nothing-more
branch
from
September 11, 2024 11:45
f77abb9
to
54ebf9d
Compare
pedrooot
force-pushed
the
PRWLR-4681-execute-should-run-the-checks-execute-and-nothing-more
branch
from
September 23, 2024 08:21
54ebf9d
to
5a15318
Compare
github-actions
bot
added
provider/aws
Issues/PRs related with the AWS provider
provider/azure
Issues/PRs related with the Azure provider
provider/gcp
Issues/PRs related with the Google Cloud Platform provider
provider/kubernetes
Issues/PRs related with the Kubernetes provider
labels
Sep 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4975 +/- ##
==========================================
+ Coverage 89.04% 89.07% +0.03%
==========================================
Files 982 982
Lines 30106 30126 +20
==========================================
+ Hits 26809 26836 +27
+ Misses 3297 3290 -7 ☔ View full report in Codecov by Sentry. |
jfagoagas
approved these changes
Sep 25, 2024
pedrooot
deleted the
PRWLR-4681-execute-should-run-the-checks-execute-and-nothing-more
branch
September 25, 2024 12:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
provider/aws
Issues/PRs related with the AWS provider
provider/azure
Issues/PRs related with the Azure provider
provider/gcp
Issues/PRs related with the Google Cloud Platform provider
provider/kubernetes
Issues/PRs related with the Kubernetes provider
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor execute method to make the minimum logic inside this method.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.