Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(execute_check): refactor execute method #4975

Conversation

pedrooot
Copy link
Member

Description

Refactor execute method to make the minimum logic inside this method.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot force-pushed the PRWLR-4681-execute-should-run-the-checks-execute-and-nothing-more branch from f77abb9 to 54ebf9d Compare September 11, 2024 11:45
@pedrooot pedrooot force-pushed the PRWLR-4681-execute-should-run-the-checks-execute-and-nothing-more branch from 54ebf9d to 5a15318 Compare September 23, 2024 08:21
@github-actions github-actions bot added provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider labels Sep 25, 2024
@pedrooot pedrooot marked this pull request as ready for review September 25, 2024 10:30
@pedrooot pedrooot requested review from a team as code owners September 25, 2024 10:30
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 37.03704% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.07%. Comparing base (0e5f929) to head (3a8aa27).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
prowler/lib/check/check.py 31.11% 31 Missing ⚠️
prowler/lib/scan/scan.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4975      +/-   ##
==========================================
+ Coverage   89.04%   89.07%   +0.03%     
==========================================
  Files         982      982              
  Lines       30106    30126      +20     
==========================================
+ Hits        26809    26836      +27     
+ Misses       3297     3290       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedrooot pedrooot merged commit ebbccd0 into master Sep 25, 2024
10 of 11 checks passed
@pedrooot pedrooot deleted the PRWLR-4681-execute-should-run-the-checks-execute-and-nothing-more branch September 25, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants