Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): remove --only-logs option #5015

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Sep 12, 2024

Description

This PR remove the option to use --only-logs during execution.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners September 12, 2024 09:02
@github-actions github-actions bot added provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider labels Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (7d1fad9) to head (82e501f).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
prowler/lib/check/check.py 15.78% 16 Missing ⚠️
prowler/__main__.py 0.00% 13 Missing ⚠️
prowler/lib/logger.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5015      +/-   ##
==========================================
+ Coverage   88.97%   88.99%   +0.01%     
==========================================
  Files         950      950              
  Lines       29142    29121      -21     
==========================================
- Hits        25928    25915      -13     
+ Misses       3214     3206       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas added the no-merge Please, DO NOT MERGE this PR. label Sep 12, 2024
@jfagoagas
Copy link
Member

jfagoagas commented Sep 12, 2024

This cannot be merged yet since it introduces a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-merge Please, DO NOT MERGE this PR. provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants