-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iam): fill resource id with inline policy entity #5120
fix(iam): fill resource id with inline policy entity #5120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make sure that the status extended for the 4 iam_inline_policy_*
checks are like:
Inline policy <POLICY_NAME> attached to <ENTITY_TYPE> <ENTITY_NAME> ...
Like in check iam_inline_policy_no_administrative_privileges
.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5120 +/- ##
==========================================
+ Coverage 89.11% 89.14% +0.02%
==========================================
Files 973 974 +1
Lines 29816 29850 +34
==========================================
+ Hits 26572 26609 +37
+ Misses 3244 3241 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, can you put the resource name instead of the resource Arn in the status extended?
Also, we can get the resource type using arn.split(":")[-1].split("/")[1]
and not using that amount of lines per code for each check.
(cherry picked from commit 14ed19e)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Description
Some checks from inline policies were not adding info related with the policy entity inside the resource id.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.