Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): fill resource id with inline policy entity #5120

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

pedrooot
Copy link
Member

Description

Some checks from inline policies were not adding info related with the policy entity inside the resource id.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners September 20, 2024 14:11
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Sep 20, 2024
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure that the status extended for the 4 iam_inline_policy_* checks are like:

Inline policy <POLICY_NAME> attached to <ENTITY_TYPE> <ENTITY_NAME> ...

Like in check iam_inline_policy_no_administrative_privileges.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (65d7ba0) to head (913d844).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5120      +/-   ##
==========================================
+ Coverage   89.11%   89.14%   +0.02%     
==========================================
  Files         973      974       +1     
  Lines       29816    29850      +34     
==========================================
+ Hits        26572    26609      +37     
+ Misses       3244     3241       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, can you put the resource name instead of the resource Arn in the status extended?

Also, we can get the resource type using arn.split(":")[-1].split("/")[1] and not using that amount of lines per code for each check.

@sergargar sergargar self-requested a review September 23, 2024 13:45
@sergargar sergargar merged commit 14ed19e into master Sep 23, 2024
11 checks passed
@sergargar sergargar deleted the PRWLR-4877-slack-question-related-with-mutelist branch September 23, 2024 14:54
prowler-bot pushed a commit that referenced this pull request Sep 23, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Sep 23, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants