Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): Ensure public IP addresses are not assigned automatically #5128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarioRgzLpz
Copy link
Member

Context

Added a new check that verifies whether Amazon ECS services are configured to automatically assign public IP addresses. The check fails if AssignPublicIP is ENABLED and passes if AssignPublicIP is DISABLED.

A public IP address is an IP address that is reachable from the internet. If you launch your Amazon ECS instances with a public IP address, then your Amazon ECS instances are reachable from the internet. Amazon ECS services should not be publicly accessible, as this may allow unintended access to your container application servers.

Description

Changed ecs_service.py to add the new Service model and two new methods to list and describe services. Added new ecs_service_no_assign_public_ip.py with respective unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MarioRgzLpz MarioRgzLpz requested review from a team as code owners September 20, 2024 16:46
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant