-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(azure): deprecate AzureGermanCloud
#5561
chore(azure): deprecate AzureGermanCloud
#5561
Conversation
AzureGermanCloud
You can check the documentation for this PR here -> Prowler Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this since it is not a breaking change in Prowler because the Germany Azure region was deprecated even before having Azure as a provider in Prowler.
Thank you for taking care of this @puchy22 👏
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5561 +/- ##
==========================================
- Coverage 89.75% 89.72% -0.03%
==========================================
Files 1090 1090
Lines 33767 33766 -1
==========================================
- Hits 30309 30298 -11
- Misses 3458 3468 +10 ☔ View full report in Codecov by Sentry. |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
(cherry picked from commit 628d50c)
Context
The Germany Dedicated zone is no longer supported as an authority host, as it was phased out in favor of the public cloud, as indicated in this Microsoft post.
The decision to deprecate it now follows a recent discussion in the official Microsoft SDK repository, where they suggested issuing a warning instead of immediately deprecating the feature. Since it was not functioning in our code due to the non-existence of the referenced endpoint, we have decided to remove all code related to this region.
Description
azure-identity
AzureGermanCloud
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.