Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(azure): deprecate AzureGermanCloud #5561

Merged

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Oct 29, 2024

Context

The Germany Dedicated zone is no longer supported as an authority host, as it was phased out in favor of the public cloud, as indicated in this Microsoft post.

The decision to deprecate it now follows a recent discussion in the official Microsoft SDK repository, where they suggested issuing a warning instead of immediately deprecating the feature. Since it was not functioning in our code due to the non-existence of the referenced endpoint, we have decided to remove all code related to this region.

Description

  • Update version of azure-identity
  • Remove all code related with AzureGermanCloud

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners October 29, 2024 11:41
@puchy22 puchy22 changed the title chore(azure): deprecate Germany dedicated zone chore(azure): deprecate AzureGermanCloud Oct 29, 2024
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions github-actions bot added documentation provider/azure Issues/PRs related with the Azure provider labels Oct 29, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it is not a breaking change in Prowler because the Germany Azure region was deprecated even before having Azure as a provider in Prowler.

Thank you for taking care of this @puchy22 👏

@puchy22 puchy22 added backport-to-v3 Backport PR to the v3 branch backport-to-v4.4 Backport PR to the v4.4 branch labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (f70e3de) to head (a88d393).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5561      +/-   ##
==========================================
- Coverage   89.75%   89.72%   -0.03%     
==========================================
  Files        1090     1090              
  Lines       33767    33766       -1     
==========================================
- Hits        30309    30298      -11     
- Misses       3458     3468      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit 628d50c into master Oct 29, 2024
13 of 14 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5007-investigate-and-fix-azure-germany-auth-constant branch October 29, 2024 13:54
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Oct 29, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v3
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

puchy22 added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v3 Backport PR to the v3 branch backport-to-v4.4 Backport PR to the v4.4 branch documentation provider/azure Issues/PRs related with the Azure provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants