Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): temporal fix for the alpine-python segmentation fault #6109

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

AdriiiPRodri
Copy link
Contributor

@AdriiiPRodri AdriiiPRodri commented Dec 10, 2024

Context

There is a problem with the current version of Python with Alpine 3.21, according to our tests there is a segmentation fault when building images that depend on this base: docker-library/python#993

Description

We have decided to fix the Alpine versions to 3.20.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AdriiiPRodri AdriiiPRodri added the backport-to-v5.0 Backport PR to the v5.0 branch label Dec 10, 2024
@AdriiiPRodri AdriiiPRodri self-assigned this Dec 10, 2024
@AdriiiPRodri AdriiiPRodri requested a review from a team as a code owner December 10, 2024 13:14
@AdriiiPRodri AdriiiPRodri force-pushed the fix-alpine_image_segfault branch from de97daf to 95131d1 Compare December 10, 2024 13:19
@AdriiiPRodri AdriiiPRodri force-pushed the fix-alpine_image_segfault branch from 95131d1 to 09d588d Compare December 10, 2024 13:20
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (38a0d2d) to head (09d588d).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6109      +/-   ##
==========================================
+ Coverage   89.92%   89.95%   +0.02%     
==========================================
  Files        1148     1148              
  Lines       35629    35629              
==========================================
+ Hits        32039    32049      +10     
+ Misses       3590     3580      -10     
Flag Coverage Δ
prowler 89.95% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.95% <ø> (+0.02%) ⬆️
api ∅ <ø> (∅)

@jfagoagas jfagoagas merged commit 21bbdcc into master Dec 10, 2024
11 checks passed
@jfagoagas jfagoagas deleted the fix-alpine_image_segfault branch December 10, 2024 15:27
prowler-bot pushed a commit that referenced this pull request Dec 10, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 10, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@jfagoagas jfagoagas added backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch labels Dec 13, 2024
@pedrooot pedrooot removed the was-backported The PR was successfully backported to the target branch label Dec 13, 2024
@jfagoagas jfagoagas added backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch and removed backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch labels Dec 13, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 13, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v3
v4.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v3
v4.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants