Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compromise between issues #75 and #108 #109

Merged
merged 3 commits into from
Nov 13, 2016
Merged

Compromise between issues #75 and #108 #109

merged 3 commits into from
Nov 13, 2016

Conversation

MVKozlov
Copy link
Contributor

@MVKozlov MVKozlov commented Oct 3, 2016

Try to reconcile issues #75 and #108

Should note that invoke Start-RSJob with -Batch parameter use the same runspace and thus environment(functions/modules/etc) filled only on the first run...
but if second run will be long after first completed, then new environment can be generated because runspace clean can happen in between runs.

Ergo... user must be notified: when use several calls to Start-RSJob with same -Batch name - the calls must use the same environment -XXX-toImport parameters or result will be unpredictable

@proxb
Copy link
Owner

proxb commented Oct 4, 2016

This seems to have failed the unit test for some reason. I do have most of this already put together and I just need to do a little more testing before it gets published (probably this weekend). I would say to hold off on this until I release what I have and we can re-engage on this and see how things look.

@MVKozlov
Copy link
Contributor Author

MVKozlov commented Oct 4, 2016

Both module variants fail test on timeout while

Describing Module OnRemove Actions PS
   Context Strict mode

btw, $PSVersion set commented out.
And test not timed out, it hang on Remove-Module.

@proxb proxb merged commit 8e128ad into proxb:master Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants