Skip to content

Add missing includes / don't include standard headers in namespaces #364

Closed
@mkauf

Description

@mkauf

There are some missing includes. On some systems, these includes may not be necessary (because they are contained in other system headers).

I have found these while compiling Envoy proxy on Fedora 38.

vm_id_handle.h:

  • #include <string>
  • #include <string_view>

wasm_vm.h:

  • #include <string_view>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions