Skip to content

Fix for V8 build on s390x. (#197) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

knm3000
Copy link
Contributor

@knm3000 knm3000 commented Jan 7, 2022

This fix enables build with v8 on s390x.
Too many diffs because it is a patch of a patch. The real changes for bazel/defs.bzl are:

  1. def _default_args():
+        }) + select({
+            "@v8//bazel/config:is_s390x": [
+                "-fno-integrated-as",
+            ],
  1. def _v8_target_cpu_transition_impl(settings, attr):
+        "s390x": "s390x",

Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
@PiotrSikora
Copy link
Member

  1. def _default_args():
+        }) + select({
+            "@v8//bazel/config:is_s390x": [
+                "-fno-integrated-as",
+            ],

Thanks! I've added it to the CL upstream (https://chromium-review.googlesource.com/c/v8/v8/+/3346395).

  1. def _v8_target_cpu_transition_impl(settings, attr):
+        "s390x": "s390x",

Thanks, this one is already in the CL upstream and in my testing branch here (#211). I didn't update it on the master branch yet, because we're still in process of reviewing the patches from the original patchset. Once the remaining ones are merged, I'll update V8 on the master branch.

Quick question. How did you get Bazel on s390x working? I've spent the last few days trying to build it under QEMU (to verify the V8 CL and your fix in #198), but it keeps crashing during build.

@PiotrSikora
Copy link
Member

OK, I regenerated patches in #211 on top of V8's main branch, so if you could verify that building from that PR works without any changes, that would be great. Thanks!

@PiotrSikora
Copy link
Member

Quick question. How did you get Bazel on s390x working? I've spent the last few days trying to build it under QEMU (to verify the V8 CL and your fix in #198), but it keeps crashing during build.

...and of course, right after I wrote this, I managed to build it!

@PiotrSikora
Copy link
Member

Superseded by #216, since all patches were already merged upstream.

@knm3000 knm3000 deleted the v8-s390-build branch January 11, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants