Enable onForeignFunction and proxy-specific extensions to the ABI. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
…to extending Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
reviewed
Jun 25, 2020
| } | ||
| WasmResult copyTo(WasmBase *wasm, size_t start, size_t length, uint64_t ptr_ptr, | ||
| uint64_t size_ptr) const override; | ||
| WasmResult copyFrom(size_t /* start */, size_t /* length */, string_view /* data */) override { |
There was a problem hiding this comment.
Now that this is independent from Envoy, we should probably stop using string_view to represent bytes, and use span instead.
There was a problem hiding this comment.
I'll open an issue for that. I presume that absl::Span is a suitable substitute. #28
| ContextBase *parent = parent_context_; | ||
| while (parent != previous) { | ||
| previous = parent; | ||
| parent = parent->parent_context_; |
There was a problem hiding this comment.
I think that will result in nullptr dereference when (accidentally) called on the root context itself. Maybe add a check?
There was a problem hiding this comment.
parent_context_ is never nullptr. The list is terminated by parent_context_ == this. This is enforced by the constructors for Context.
PiotrSikora
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak jplevyak@gmail.com