Skip to content

Bump v8 to version 11.2.34 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bump v8 to version 11.2.34 #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ def proxy_wasm_cpp_host_repositories():
maybe(
git_repository,
name = "v8",
# 10.7.193.13
commit = "6c8b357a84847a479cd329478522feefc1c3195a",
# 11.2.34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wrong version to update to.

The main branch of V8 isn't stable, and you should use only versions used in linux/stable or linux/beta builds of Chrome. See v8_version column here: https://omahaproxy.appspot.com.

commit = "fb6dd9c9d5034ca221e895b01072b0269f2611e7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update //base/trace_event/common below to a version that matches V8 as well.

See https://storage.googleapis.com/envoyproxy-wee8/wee8-fetch-deps.sh (or just run it) to see how it's extracted.

remote = "https://chromium.googlesource.com/v8/v8",
shallow_since = "1664374400 +0000",
shallow_since = "1675228587 -0800",
patches = ["@proxy_wasm_cpp_host//bazel/external:v8.patch"],
patch_args = ["-p1"],
)
Expand Down