Skip to content

Test an example stream context with a logging plugin #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 9, 2023

Conversation

martijneken
Copy link
Contributor

No description provided.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Copy link
Contributor Author

Friendly ping. Testing changes only, but this allows me to use TestContext / MakeVm elsewhere.

@PiotrSikora
Copy link
Member

PiotrSikora commented May 4, 2023

@mathetake @mpwarres could you take a look? Thanks!

Copy link
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod comments

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Copy link
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@mpwarres mpwarres merged commit 5574daf into proxy-wasm:master May 9, 2023
@martijneken martijneken deleted the test-stream-context branch May 9, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants