Skip to content

wavm: emit stack trace when an exception happens #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2020
Merged

wavm: emit stack trace when an exception happens #84

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5281426
wavm: emit stack trace
mathetake Oct 28, 2020
da4c2ef
review: tidy up stacktrace message
mathetake Oct 29, 2020
8100795
align trailing spaces
mathetake Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions src/wavm/wavm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#include "WAVM/Runtime/Intrinsics.h"
#include "WAVM/Runtime/Linker.h"
#include "WAVM/Runtime/Runtime.h"
#include "WAVM/RuntimeABI/RuntimeABI.h"
#include "WAVM/WASM/WASM.h"
#include "WAVM/WASTParse/WASTParse.h"

Expand Down Expand Up @@ -90,16 +91,35 @@ namespace {
WAVM::Runtime::catchRuntimeExceptions( \
[&] { _x; }, \
[&](WAVM::Runtime::Exception *exception) { \
auto description = describeException(exception); \
_wavm->fail(FailState::RuntimeError, \
"Function: " + std::string(function_name) + " failed: " + description); \
destroyException(exception); \
_wavm->fail(FailState::RuntimeError, getFailMessage(function_name, exception)); \
throw std::exception(); \
}); \
} catch (...) { \
} \
} while (0)

std::string getFailMessage(std::string_view function_name, WAVM::Runtime::Exception *exception) {
std::string message = "Function " + std::string(function_name) +
" failed: " + WAVM::Runtime::describeExceptionType(exception->type) +
"\nProxy-Wasm plugin in-VM backtrace:\n";
std::vector<std::string> callstack_descriptions =
WAVM::Runtime::describeCallStack(exception->callStack);

// Since the first frame is on host and useless for developers, e.g.: `host!envoy+112901013`
// we start with index 1 here
for (size_t i = 1; i < callstack_descriptions.size(); i++) {
std::string description = callstack_descriptions[i];
if (description.find("wasm!") == std::string::npos) {
// end of WASM's call stack
break;
}
message += " " + std::to_string(i) + ": " + description + "\n";
}

WAVM::Runtime::destroyException(exception);
return message;
}

struct WasmUntaggedValue : public WAVM::IR::UntaggedValue {
WasmUntaggedValue() = default;
WasmUntaggedValue(I32 inI32) { i32 = inI32; }
Expand Down