chore: update bazel to 7.6.1 and migrate to bzlmod #189
+43
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
…management Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
martijneken
reviewed
Sep 10, 2025
| @@ -7,3 +7,5 @@ | |||
| # enables improved Bazel C++ toolchain resolution method that became the | |||
| # default in newer Bazel version and does not cause problems, we keep it. | |||
| build --incompatible_enable_cc_toolchain_resolution | |||
| # Enable Bzlmod for every Bazel command | |||
| common --enable_bzlmod | |||
There was a problem hiding this comment.
This looks great to me, thanks for the PR!
Pardon my ignorance, one question: please confirm this setting isn't contagious and that the change is compatible with non-bzlmod projects. What I mean is: projects like Envoy can still depend on cpp-sdk without immediately enabling bzlmod?
There was a problem hiding this comment.
The .bazelrc only impact the current project not those depending on it.
Having MODULE.bazel and WORKSPACE allow to support both modes during the migration.
I'm actually trying to migrate envoy to bzlmod but the more dependencies are still using WORKSPACE, the harder it is , see envoyproxy/envoy#40692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates bazel to 7.6.1 and migrate to bzlmod
Closes #187