Add proxy_wasm::main macro. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is primarly a mechanism to deliver a workaround for a breaking change in Rust v1.56.0 (which updated LLVM to v13.0), which changed existing reactors into multi-entry commands, leading to performance degradation and/or unusable Proxy-Wasm plugins. See: WebAssembly/WASI#471 This is delivered as a macro to make it somehow compatible with the unstable "-Z wasi-exec-model=reactor" feature. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Swaagie
approved these changes
Apr 6, 2022
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
commented
Apr 7, 2022
|
|
||
| - Fixed performance degradation with `wasm32-wasi` target in Rust v1.56.0 | ||
| or newer by adding `proxy_wasm::main` macro that should be used instead | ||
| of custom `_start`, `_initialize` and/or `main` exports. |
There was a problem hiding this comment.
@Swaagie @mathetake updated text to make it more clear that it's a fix and not simply a new feature. PTAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarly a mechanism to deliver a workaround for a breaking
change in Rust v1.56.0 (which updated LLVM to v13.0), which changed
existing reactors into multi-entry commands, leading to performance
degradation and/or unusable Proxy-Wasm plugins.
See: WebAssembly/WASI#471
This is delivered as a macro to make it somehow compatible with the
unstable "-Z wasi-exec-model=reactor" feature.
Signed-off-by: Piotr Sikora piotrsikora@google.com