Add Envoy filter metadata example. #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaagie
force-pushed
the
metadata-example
branch
3 times, most recently
from
4077239 to
63e7058
Compare
PiotrSikora
requested changes
Nov 26, 2024
Swaagie
force-pushed
the
metadata-example
branch
2 times, most recently
from
24dd22c to
345678d
Compare
|
@PiotrSikora suggestions have been implemented edit: requires #291 (review) to pass checks. |
jcruger-godaddy
approved these changes
Nov 30, 2024
|
Could you add this to the CI as well? Simply add entry to the matrices in the |
PiotrSikora
reviewed
Dec 2, 2024
Swaagie
force-pushed
the
metadata-example
branch
2 times, most recently
from
af11338 to
cdc339a
Compare
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Swaagie
force-pushed
the
metadata-example
branch
from
cdc339a to
b96a374
Compare
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #288. Happy to adjust this to where it has the most value/clear use cases.