Fix HTTP body example. #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
commented
Aug 14, 2020
| } | ||
|
|
||
| fn on_http_response_body(&mut self, body_size: usize, end_of_stream: bool) -> Action { | ||
| self.total_body_size += body_size; |
There was a problem hiding this comment.
Hi @gbrail, I'm not sure how I've missed this change while reviewing your PR. I think I just assumed that you've applied suggested changes and I merged it without thinking... In any case, on_http_response_body reports total buffered body size, not only the most recent chunk (that was a regression in Envoy-Wasm, see: envoyproxy/envoy-wasm#608).
There was a problem hiding this comment.
Yes -- before the callback was getting only the size of the current chunk -- with this fix the code is much simpler. Thanks.
gbrail
approved these changes
Aug 14, 2020
| } | ||
|
|
||
| fn on_http_response_body(&mut self, body_size: usize, end_of_stream: bool) -> Action { | ||
| self.total_body_size += body_size; |
There was a problem hiding this comment.
Yes -- before the callback was getting only the size of the current chunk -- with this fix the code is much simpler. Thanks.
nullpo-head
pushed a commit
to nullpo-head/proxy-wasm-rust-sdk
that referenced
this pull request
Mar 2, 2021
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
yskopets
added a commit
to yskopets/proxy-wasm-rust-sdk
that referenced
this pull request
Mar 2, 2021
* Use Rust toolchains with working components. (#16) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Split licenses check into a separate test target. (#17) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Help other developers get started using this SDK. (#15) Signed-off-by: DazWilkin <daz.wilkin@gmail.com> * Add Bazel support. (#18) Signed-off-by: Shikugawa <Shikugawa@gmail.com> Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for setting HTTP bodies. (#2) Signed-off-by: Gregory Brail <gregbrail@google.com> * Release v0.1.1. (#20) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update MapType values to match updated Proxy-Wasm ABI v0.1.0. (#7) Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io> * Release v0.1.2. (#21) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update hashbrown to v0.8.2. (#22) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add cargo audit and cargo outdated checks. (#23) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update chrono to v0.4.15. (proxy-wasm#33) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Move optional checks to the end. (proxy-wasm#28) While there, align style with the test framework. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Move Bazel to //bazel. (proxy-wasm#29) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Fix HTTP body example. (proxy-wasm#32) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for setting network buffers. (proxy-wasm#31) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add metrics. (proxy-wasm#30) Fixes #4. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update hashbrown and transitive dependencies. (proxy-wasm#45) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Allow building for wasm32-wasi target. (proxy-wasm#42) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Make wee-alloc an optional feature. (proxy-wasm#38) Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com> * Update rules_rust to latest. (proxy-wasm#46) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update cargo-raze to latest and regenerate artifacts. (proxy-wasm#47) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Allow building for wasm32-wasi target using Bazel. (proxy-wasm#50) While there, update Bazel to 3.7.0. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Show getrandom and chrono/time usage in examples. (proxy-wasm#51) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Use cargo-raze's gen_buildrs for trusted crates. (proxy-wasm#53) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for nested HTTP callouts. (proxy-wasm#56) Signed-off-by: Svetlin Zarev <svetlin.zarev@sap.com> * Allow RootContext to create child contexts for streams. (proxy-wasm#34) Fixes #6. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix warnings from Clippy v1.50.0 (nightly). (proxy-wasm#58) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Release v0.1.3. (proxy-wasm#59) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup instructions for updating dependencies. (proxy-wasm#60) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup WORKSPACE. (proxy-wasm#61) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup examples. (proxy-wasm#62) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update libc (transitive dependency) to v0.2.81. (proxy-wasm#63) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update the declared ABI version to 0.2.0 Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Update the examples so that they use the latest API Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Remove ChildContext for now, which is not used anymore Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Bump the version to 0.0.8 Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix bazel build for the fork's crate Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix clippy erros in bytestring.rs Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Update dependencies Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix Cargo.toml Signed-off-by: Takaya Saeki <takaya@tetrate.io> * outdated should check only root deps Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix inconsistent derived traits Signed-off-by: Takaya Saeki <takaya@tetrate.io> Co-authored-by: Piotr Sikora <piotrsikora@google.com> Co-authored-by: Daz Wilkin <DazWilkin@users.noreply.github.com> Co-authored-by: Greg Brail <gbrail@users.noreply.github.com> Co-authored-by: Yaroslav Skopets <y.skopets@gmail.com> Co-authored-by: Yuval Kohavi <yuval.kohavi@gmail.com> Co-authored-by: SvetlinZarev-SAP <43135961+SvetlinZarev-SAP@users.noreply.github.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
github-actions bot
pushed a commit
to yskopets/proxy-wasm-rust-sdk
that referenced
this pull request
Mar 2, 2021
* Use Rust toolchains with working components. (#16) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Split licenses check into a separate test target. (#17) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Help other developers get started using this SDK. (#15) Signed-off-by: DazWilkin <daz.wilkin@gmail.com> * Add Bazel support. (#18) Signed-off-by: Shikugawa <Shikugawa@gmail.com> Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for setting HTTP bodies. (#2) Signed-off-by: Gregory Brail <gregbrail@google.com> * Release v0.1.1. (#20) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update MapType values to match updated Proxy-Wasm ABI v0.1.0. (#7) Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io> * Release v0.1.2. (#21) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update hashbrown to v0.8.2. (#22) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add cargo audit and cargo outdated checks. (#23) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update chrono to v0.4.15. (proxy-wasm#33) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Move optional checks to the end. (proxy-wasm#28) While there, align style with the test framework. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Move Bazel to //bazel. (proxy-wasm#29) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Fix HTTP body example. (proxy-wasm#32) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for setting network buffers. (proxy-wasm#31) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add metrics. (proxy-wasm#30) Fixes #4. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update hashbrown and transitive dependencies. (proxy-wasm#45) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Allow building for wasm32-wasi target. (proxy-wasm#42) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Make wee-alloc an optional feature. (proxy-wasm#38) Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com> * Update rules_rust to latest. (proxy-wasm#46) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update cargo-raze to latest and regenerate artifacts. (proxy-wasm#47) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Allow building for wasm32-wasi target using Bazel. (proxy-wasm#50) While there, update Bazel to 3.7.0. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Show getrandom and chrono/time usage in examples. (proxy-wasm#51) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Use cargo-raze's gen_buildrs for trusted crates. (proxy-wasm#53) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for nested HTTP callouts. (proxy-wasm#56) Signed-off-by: Svetlin Zarev <svetlin.zarev@sap.com> * Allow RootContext to create child contexts for streams. (proxy-wasm#34) Fixes #6. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix warnings from Clippy v1.50.0 (nightly). (proxy-wasm#58) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Release v0.1.3. (proxy-wasm#59) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup instructions for updating dependencies. (proxy-wasm#60) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup WORKSPACE. (proxy-wasm#61) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup examples. (proxy-wasm#62) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update libc (transitive dependency) to v0.2.81. (proxy-wasm#63) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update the declared ABI version to 0.2.0 Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Update the examples so that they use the latest API Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Remove ChildContext for now, which is not used anymore Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Bump the version to 0.0.8 Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix bazel build for the fork's crate Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix clippy erros in bytestring.rs Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Update dependencies Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix Cargo.toml Signed-off-by: Takaya Saeki <takaya@tetrate.io> * outdated should check only root deps Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix inconsistent derived traits Signed-off-by: Takaya Saeki <takaya@tetrate.io> Co-authored-by: Piotr Sikora <piotrsikora@google.com> Co-authored-by: Daz Wilkin <DazWilkin@users.noreply.github.com> Co-authored-by: Greg Brail <gbrail@users.noreply.github.com> Co-authored-by: Yaroslav Skopets <y.skopets@gmail.com> Co-authored-by: Yuval Kohavi <yuval.kohavi@gmail.com> Co-authored-by: SvetlinZarev-SAP <43135961+SvetlinZarev-SAP@users.noreply.github.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
github-actions bot
pushed a commit
to nullpo-head/proxy-wasm-rust-sdk
that referenced
this pull request
Apr 20, 2021
…opets#19) * Use Rust toolchains with working components. (yskopets#16) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Split licenses check into a separate test target. (yskopets#17) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Help other developers get started using this SDK. (yskopets#15) Signed-off-by: DazWilkin <daz.wilkin@gmail.com> * Add Bazel support. (yskopets#18) Signed-off-by: Shikugawa <Shikugawa@gmail.com> Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for setting HTTP bodies. (yskopets#2) Signed-off-by: Gregory Brail <gregbrail@google.com> * Release v0.1.1. (yskopets#20) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update MapType values to match updated Proxy-Wasm ABI v0.1.0. (yskopets#7) Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io> * Release v0.1.2. (yskopets#21) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update hashbrown to v0.8.2. (yskopets#22) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add cargo audit and cargo outdated checks. (yskopets#23) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update chrono to v0.4.15. (proxy-wasm#33) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Move optional checks to the end. (proxy-wasm#28) While there, align style with the test framework. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Move Bazel to //bazel. (proxy-wasm#29) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Fix HTTP body example. (proxy-wasm#32) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for setting network buffers. (proxy-wasm#31) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add metrics. (proxy-wasm#30) Fixes yskopets#4. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update hashbrown and transitive dependencies. (proxy-wasm#45) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Allow building for wasm32-wasi target. (proxy-wasm#42) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Make wee-alloc an optional feature. (proxy-wasm#38) Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com> * Update rules_rust to latest. (proxy-wasm#46) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update cargo-raze to latest and regenerate artifacts. (proxy-wasm#47) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Allow building for wasm32-wasi target using Bazel. (proxy-wasm#50) While there, update Bazel to 3.7.0. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Show getrandom and chrono/time usage in examples. (proxy-wasm#51) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Use cargo-raze's gen_buildrs for trusted crates. (proxy-wasm#53) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Add support for nested HTTP callouts. (proxy-wasm#56) Signed-off-by: Svetlin Zarev <svetlin.zarev@sap.com> * Allow RootContext to create child contexts for streams. (proxy-wasm#34) Fixes yskopets#6. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Fix warnings from Clippy v1.50.0 (nightly). (proxy-wasm#58) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Release v0.1.3. (proxy-wasm#59) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup instructions for updating dependencies. (proxy-wasm#60) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup WORKSPACE. (proxy-wasm#61) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Cleanup examples. (proxy-wasm#62) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update libc (transitive dependency) to v0.2.81. (proxy-wasm#63) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update the declared ABI version to 0.2.0 Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Update the examples so that they use the latest API Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Remove ChildContext for now, which is not used anymore Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Bump the version to 0.0.8 Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix bazel build for the fork's crate Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix clippy erros in bytestring.rs Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Update dependencies Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix Cargo.toml Signed-off-by: Takaya Saeki <takaya@tetrate.io> * outdated should check only root deps Signed-off-by: Takaya Saeki <takaya@tetrate.io> * Fix inconsistent derived traits Signed-off-by: Takaya Saeki <takaya@tetrate.io> Co-authored-by: Piotr Sikora <piotrsikora@google.com> Co-authored-by: Daz Wilkin <DazWilkin@users.noreply.github.com> Co-authored-by: Greg Brail <gbrail@users.noreply.github.com> Co-authored-by: Yaroslav Skopets <y.skopets@gmail.com> Co-authored-by: Yuval Kohavi <yuval.kohavi@gmail.com> Co-authored-by: SvetlinZarev-SAP <43135961+SvetlinZarev-SAP@users.noreply.github.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora piotrsikora@google.com