Give dispute stream a 90-day lookback window. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarabed15
force-pushed
the
DT-3007-disputes-incremental-logic
branch
from
4d06194 to
a5ebe06
Compare
hkuffel
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the lookback window for the
disputesstream to 90 days, from 1 day.This was done because we are fetching dispute objects, not events, from the Stripe stream, so we are not capturing updates to the dispute objects by using a 1-day lookback. By increasing the lookback window, we will capture updates to any dispute objects created in the last 90 days.
Tests
Executed the tap through the meltano project with:
meltano --environment=dev elt tap-stripe target-jsonl --job_id=elt-stripe-to-json --select disputesSaw results going back to
Friday, October 27, 2023 11:13:33 PMin the JSON output.Execution took under 25 seconds: