idler/selector: simplify init #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The homing is always invalidated in all cases. Let's simply invalidate the homing only in the init method. The state machine's Ready state then decides when it is OK to perform the homing move. We shouldn't need to guess the axis's position, and should assume its not correct. Currently the init methods are only called during the boot up sequence. Change in memory: Flash: -126 bytes SRAM: 0 bytes
|
All values in bytes. Δ Delta to base
|
Automated Test Code Coverage ReportView details...
TOTAL: 2721 lines of code, 2030 lines executed, 74% covered. |
leptun
reviewed
Dec 25, 2024
There was a problem hiding this comment.
I am a bit suspicious of the selector changes. Need to check if the mmu can unload from the scenario of reset with filament loaded. Previously the axis position was invalidated, but the position itself still matched the loaded slot. Now it no longer matches and I wonder if the logic properly handles that
DRracer
requested changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The homing is always invalidated in all cases. Let's simply invalidate the homing only in the init method. The state machine's
Readystate then decides when it is OK to perform the homing move.We shouldn't need to guess the axis's position, its safer (and simpler) to assume its always incorrect. Currently the init methods are only called during the boot up sequence.
This change passes the unit tests
Change in memory:
Flash: -126 bytes
SRAM: 0 bytes