Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Acceleration/Jerk limits do not survive a power panic #2456

Closed
wavexx opened this issue Feb 2, 2020 · 5 comments
Closed

[BUG] Acceleration/Jerk limits do not survive a power panic #2456

wavexx opened this issue Feb 2, 2020 · 5 comments
Assignees
Milestone

Comments

@wavexx
Copy link
Collaborator

wavexx commented Feb 2, 2020

Printer type - MK2.5/MK2.5S/MK3/MK3S
Printer firmware version- 3.9.0+

Describe the bug
Acceleration and Jerk limits are generally set at the beginning of a print and are usually different to default settings (or eeprom values).

These values currently do not survive a power panic, but they should.
On restart default values are reloaded, which will result in different printing behavior.

@wavexx wavexx added the bug label Feb 2, 2020
wavexx added a commit to wavexx/Prusa-Firmware that referenced this issue Feb 2, 2020
When upgrading K values of a LA1.0 print, also adjust E-jerk settings
(<2) if permissible according to current accell limits. The same is also
true when jerk is set mid-print via 'M205 E'.

Existing values are always restored when switching to another
compatibility mode.

TODO: Since this is stateful, we will need to save the current print
mode / acceleration and jerk in the eeprom for this to survive a power
panic (see prusa3d#2456)
wavexx added a commit to wavexx/Prusa-Firmware that referenced this issue Feb 3, 2020
When upgrading K values of a LA1.0 print, also adjust E-jerk settings
(<2) if permissible according to current accell limits. The same is also
true when jerk is set mid-print via 'M205 E'.

Existing values are always restored when switching to another
compatibility mode.

TODO: Since this is stateful, we will need to save the current print
mode / acceleration and jerk in the eeprom for this to survive a power
panic (see prusa3d#2456).
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

@3d-gussner
Copy link
Collaborator

@gudnimg Aren't these now also stored in eeprom? Please verify.

@gudnimg
Copy link
Collaborator

gudnimg commented Nov 8, 2023

We definately don’t save the jerk value. Not sure about acceleration. It is very easy to add this. 👍

@gudnimg
Copy link
Collaborator

gudnimg commented Nov 12, 2023

It looks like we do save the acceleration. But we don't save the maximum jerk value.

max_jerk will require 4*4 = 16 bytes in EEPROM

We also don't save these values:

  • min_segment_time_us (4 bytes)
  • mintravelfeedrate (4 bytes)
  • minimumfeedrate (4 bytes)

@3d-gussner 3d-gussner added this to the FW 3.14.1 milestone Apr 2, 2024
3d-gussner added a commit to 3d-gussner/Prusa-Firmware that referenced this issue Apr 9, 2024
@3d-gussner
Copy link
Collaborator

Fixed with #4657

3d-gussner added a commit to 3d-gussner/Prusa-Firmware that referenced this issue Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants