#2478 MMU Jam and extruder grinding detection. #2499
Conversation
|
Test case: I just encountered this "for real" - there was some hard junk in my filament that blocked the nozzle and caused the extruder to grind. Jam detection tripped and it recovered beautifully - there was only a minor blemish in the infill it was doing when it tripped. I know it's too late for 3.9 but I really hope you consider including this in 3.9.1 or 3.10 |
|
w00t! |
|
@vintagepc You will probably end up splitting the option into two. So you have |
|
understood; Just say the word and I am happy to adjust. |
|
@vintagepc Please review your PR as there are conflicts with latest firmware release. |
There was a problem hiding this comment.
It would also very helpful if you try to update the lang_en.txt and lang_en_xx.txt (maybe even the pofiles) files.
Please read translations.md
If you don't feel comfortable with that please let me know and I will create a PR to your PR.
Firmware/mmu.cpp
Outdated
| } | ||
| else | ||
| { | ||
| lcd_display_message_fullscreen_P(_i("Remove old filament and press the knob to start loading new filament.")); |
Firmware/ultralcd.cpp
Outdated
| }\ | ||
| else\ | ||
| {\ | ||
| MENU_ITEM_TOGGLE_P(_T(MSG_FSENSOR), _T(MSG_ON), lcd_fsensor_state_set);\ |
Firmware/ultralcd.cpp
Outdated
| else { | ||
| else if (oFSensorMode==ClFSensorMode::_On_And_Jam && mmu_enabled) | ||
| { // Jam detect mode | ||
| MENU_ITEM_TOGGLE_P(_T(MSG_FSENSOR), _T(MSG_ON_JAM), lcd_fsensor_state_set); |
|
I will have a look - I intend to break out the jam detection option due to length constraints. |
|
@3d-gussner Can you clarify the nature of the "c" and "r" values? Is it to document the maximum length used by the biggest language? |
|
I've reworked the menu to be two separate items, though they still share the same EEPROM byte, and pushed up a partial.
I did try to do the language stuff but I think I'm doing something wrong. After doing the lang_add.sh lang_add.txt, it adds them to the text files, but it does not appear to tag them with the correct identifier despite the comments in the code. AFAICT they are structured similarly to other nearby items so it's not obvious to me what is wrong: example .txt content: |
|
@vintagepc we'd like to postpone this PR after FW 3.10 as there will be some greater care devoted to the MMU itself. Therefore I'm removing the 3.10 tag from this PR. |
|
I'll hold you to that 😛 |
|
@vintagepc Please check if this is still a valid PR. If so please rebase update and add a miles stone to it. |
|
Closing because the code it was based on is obsolete |
Filing a PR since I think this is ready for more general review and consideration.
This closes #2478 and the original #2214
The theory here is to detect a jam/ground filament state by also monitoring the extruder filament sensor in addition to the FINDA. If grinding is detected, the MMU goes into "attention required" state to hopefully let the user fix the issue and resume the print, rather than continuing blindly and printing air for the remainder.
This feature can be easily disabled via the Filament sensor setting item if false positives are a problem for certain filaments (e.g. flex).
There are more implementation details and some test outlines/screen pics in #2478.
Items TBD:
Find a solution for the new F. Sensor menu choice being 1 char too long (some options proposed in linked issue, may require language/translator input)I could not come up with anything more succinct than "+Jam" to indicate it's on + jam detection mode.