Remove recursion workaround in Nozzle Change #4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
|
Note: this PR is related to #4703 We should not be adding more “hacks” like this to add the unload filament dialog :) |
gudnimg
force-pushed
the
cleanup_recursion_hack
branch
from
83773d9 to
7b70f6a
Compare
|
Opening this PR up for review. Nozzle change works well on my MK3S+. There may be regressions introduced by 7b70f6a but I think this is a good change. |
This fix is no longer needed today. LCD knob clicks / and rotation, take care of updating lcd_draw_update. The real bug was likely lcd_show_multiscreen_message_yes_no_and_wait_P calling lcd_update(), this is fixed now since.
The fixes a scenario where: lcd_status_screen() calls lcd_commands() upon exiting lcd_show_fullscreen_message_and_wait_P(_T(MSG_NOZZLE_CNG_READ_HELP)); and so not allowing the user to leave the screen since it will keep being rendered endlessly. This change only affects lcd_show_fullscreen_message_and_wait_P
gudnimg
force-pushed
the
cleanup_recursion_hack
branch
from
7b70f6a to
25a11bb
Compare
3d-gussner
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround isn't needed today. At the time this workaround was added,
lcd_show_multiscreen_message_yes_no_and_wait_Pwas callinglcd_update()vialcd_update_enable(true)which caused all sorts of problems like first layer calibration being inaccessible.When testing this PR, I found one more place where
lcd_update()was being called: 7b70f6a which has now been eliminated. This change is required to fully remove the workaround.Steps to test: