Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimze and new first layer calibration #4811

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Optimze and new first layer calibration #4811

merged 13 commits into from
Nov 27, 2024

Conversation

3d-gussner
Copy link
Collaborator

By default the previous known first layer calibration pattern is used. You need to un-comment //#define NEW_FIRST_LAYER_CAL in the variant file to use the new pattern from front to rear.

The new first layer calibration pattern from front to rear with square ends in the middle of the bed.

  • The calibration of the first layer at the center is most important
  • The left, right, front rear sides can manually corrected via LCD -> Calibration -> Bed level correct menu
  • The first layer calibration pattern continues directly after the purge to keep the pressure stable in the nozzle

New_first_layer_cal

@3d-gussner 3d-gussner requested review from gudnimg and leptun November 14, 2024 13:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG -546 0 247756 5654 6196 2538
MK3_MULTILANG -546 0 247126 5663 6826 2529

@3d-gussner
New first layer calibration
d1470d8 
- changed to relative mode to save buffer and code size
- added NEW_FIRST_LAYER_CAL to perform 1st layer cal from front to back
@3d-gussner 3d-gussner force-pushed the MK3_new_1st_layer_cal branch from d095d86 to d1470d8 Compare November 14, 2024 13:45
@3d-gussner

This comment was marked as outdated.

Sign in to view
gudnimg
gudnimg reviewed Nov 16, 2024
View reviewed changes
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
@gudnimg gudnimg mentioned this pull request Nov 16, 2024
Closed
gudnimg
gudnimg reviewed Nov 16, 2024
View reviewed changes
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
leptun
leptun requested changes Nov 17, 2024
View reviewed changes
Firmware/first_lay_cal.cpp Show resolved Hide resolved
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
Firmware/first_lay_cal.cpp Show resolved Hide resolved
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
gudnimg
gudnimg reviewed Nov 18, 2024
View reviewed changes
Firmware/ultralcd.cpp Outdated Show resolved Hide resolved
gudnimg
gudnimg reviewed Nov 18, 2024
View reviewed changes
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
gudnimg
gudnimg reviewed Nov 18, 2024
View reviewed changes
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
gudnimg
gudnimg reviewed Nov 18, 2024
View reviewed changes
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
gudnimg
gudnimg reviewed Nov 19, 2024
View reviewed changes
Firmware/first_lay_cal.cpp Outdated Show resolved Hide resolved
gudnimg and others added 7 commits November 19, 2024 19:50
@gudnimg @leptun
optimisation: combine a few functions calls into one
e84ade3 
Change in memory:
Flash: -34 bytes
SRAM: 0 bytes
@leptun
Get rid of float casts
13d12c0
@leptun
Minor nitpicks
81d124a
@leptun
Ensure all meander moves are done using relative mode
519724b 
Without this the first vertical move of the new meander would be slightly longer than expected due to using absolute moves from a negative Y starting position
@leptun
Optimize meander moves
24ce71e
@leptun
Fix end of meander overextrusion with new pattern
7a47bf3
@3d-gussner
Switch back from %g to .4f
b67554e 
Set short length so the square is printed in the middle of the bed
Both purge lines with and without MMU end at X=202.5 to get the square in the middle of the bed
@3d-gussner 3d-gussner requested review from leptun and gudnimg November 20, 2024 11:26
gudnimg
gudnimg approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, I'd like to see @leptun approve as well. Or at least 2nd approval :)

leptun
leptun approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@leptun leptun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both calibration versions in MK404 with fancy extrusion and colored extrusion based on width. Looks good to me. Only tested with 0.4mm nozzle

@3d-gussner
Copy link
Collaborator Author

@gudnimg @leptun Thanks for the feedback and review.

@3d-gussner 3d-gussner merged commit b7e3216 into prusa3d:MK3 Nov 27, 2024
4 checks passed
@3d-gussner 3d-gussner deleted the MK3_new_1st_layer_cal branch November 27, 2024 08:10
This was referenced Dec 2, 2024
Closed
Open
@jedisct1
Copy link

jedisct1 commented Jan 6, 2025

Been running my MK3S+ with NEW_FIRST_LAYER_CAL for a while, and it works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leptun leptun leptun approved these changes

@gudnimg gudnimg gudnimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@3d-gussner @jedisct1 @gudnimg @leptun