Concentric infil has gaps that can be filled with straight lines

[madsi1m]

Version

1.41.2+win64

Operating system type + version

Windows Server 2016 x64

Behavior

When using concentric infill for top+bottom, some times (depending on shape) the concentric infill leaves gaps as shown here:

It looks like concentric fill needs to check that the layer if full as in the above example clearly shows gaps that should have been filled.

Looking forward to a solution, keep up the good work.

[supermerill]

Duplicate of #577
(and #662)
Same as slic3r/Slic3r#4629 ; slic3r/Slic3r#4560

[bubnikv]

The concentric infill is missing a final gap fill.

[supermerill]

if you want the code for "final gap fill": supermerill/SuperSlicer@60442ba
I can make a pr also.

Note that it uses some code i added with the ironing infill (making the no_sort parameter working)

[bubnikv]

I appreciate your offer. I am looking forward into merging your extensions, but we have to roll the current build out of the door first.

…

On Tue, Jan 29, 2019 at 4:19 PM Merill ***@***.***> wrote: if you want the code for "final gap fill": ***@***.*** <supermerill@60442ba> I can make a pr also. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1461 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFj5IxoGeJxW1Gc4Daw1jwjmctSFhwu5ks5vIGaUgaJpZM4ZJ8_B> .

[madsi1m]

Awesome!!

[jurriaan]

@bubnikv Is this still on your radar? Concentric infill is not really usable in its current state.

[bubnikv]

It is on the radar, together with the other 938 issues.

[madsi1m]

@supermerill I think a pull request would push for a fix in an official release a bit faster than not having one.

In the mean time i am using arch curves and faking the center position

[stephen304]

if you want the code for "final gap fill": supermerill/Slic3r@60442ba
I can make a pr also.

Note that it uses some code i added with the ironing infill (making the no_sort parameter working)

@supermerill Is that commit the only one needed to fix? I'm thinking of cherry picking and compiling myself because I need this for printing ear savers for local hospitals as fast as possible.

[supermerill]

@stephen304 i don't know, fill.cpp has changed in the meantime.
You may have to merge some more things from my fork, like the changes for the infill pattern api. Also I don't really know how well the no_sort is handled in prusaslicer at this time (better than before, for sure). I don't think trying to merge that code is the fatest way to use it.

The basic idea is to transpose the way gapfill is made for perimeters into this. And then add these gap fill extrusions after (and only after) the fill was performed. But i also improved the gap fil a lot in my fork .... currently in prusasicer, gap fill can have some issues. There are a lot of code to merge to be able to get a good result.

[tspannagel]

This is still an issue. The Gaps produced are really big.

In the image you could place 2-3lines in the gaps. (im currently usin pursa slicer 2.4

[supermerill]

In the image you could place 2-3lines in the gaps. (im currently usin pursa slicer 2.4

If I copy-paste two lines, they don't fit (but not by much).

[tspannagel]

superslicer offers a solution for this issue -> "concentric (filled)". Maybe its possible to merge this feature back?

[supermerill]

Maybe its possible to merge this feature back?

It needs to have my new Fill api, to be able to output multiple extrusion types, ordered. Not a very big deal.
I sadly also had to deactivate the greedy reordering and fall back to the 'closest point' one as it doesn't like when the extrusions are ordered. So for a clean merge, this complicated algorithm has to be enhanced.
If these two are merged then it's just the matter of copying two blocks of code.

But IMO, it's still a bit subpar and needs a bit of improvement to be able to 'merge' the gapfill lines into the loops to reduce the travels, I'm working on it.

[bubnikv]

Implemented in PrusaSlicer 2.5.0-alpha2.

In PrusaSlicer 2.5.0-alpha2 we have ported the Arachne perimeter generator from Cura. Thanks Ultimaker and Cura team for keeping Cura open and for their dedication.
With Arachne enabled for perimeters, the Arachne is newly used to fill in concentric infill completely.

Closing.