-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: "Switching Presets: Unsaved Changes" table #7393
Labels
Comments
We implemented your FR to upcoming 2.6.0. There are three columns for comparing original, modified, and new values for presets. |
mmalecki
pushed a commit
to mmalecki/PrusaSlicer
that referenced
this issue
Feb 1, 2023
Return values, when preset i sactive: - edited_preset, when respect_active_preset==true - selected_preset, when respect_active_preset==false + UnsavedChangedDialog: Implementation for FR prusa3d#7393 - "Switching Presets: Unsaved Changes" table + DiffDialog: Implemented possibility to compare selected and edited presets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
version_2.4.0-beta2 (2c5ddfe)
Operating system type + version
macOS 11.6 (20G165)
Behavior
After modifying preset values, PS displays a table with old and new values to either transfer or discard when changing to a different preset.
The table has "Old value" and "New value" columns. To me that always meant: "Changed value" and "new preset's value". But it seems it might be "original value" and "changed value" of the old preset?
Suggestion
I do think it might be easier to understand those values by renaming the columns to something like "Original preset", "Modified value" and perhaps add another column for "New preset" to fully see what was changed into what and how it differs from the chosen new preset?
The text was updated successfully, but these errors were encountered: