Fix missing cubic infill line

[KoKuToru]

I suppose the lines are shifted somehow like offset -= (layer_z) % spacing (couldn't find where/how it's done..) and so it will need an extra line sometimes..

Anyways adding 1 extra line fixes the problem. No idea if this has ugly side effects..

[bubnikv]

Luca,

the connecting lines are an intended behavoir and they serve to better
anchor the infill lines to the inner perimeters. The connecting lines are
an inherent feature of most of the infill and Simplify3D or kisslicer do
them. Cure does not.

And ineed our print expert guy Jindra asked for selectively removing the
connecting lines for the transparent prints. The way I plan to do it is by
using the link_max_length property of the Fill class, where you set the
scaled allowed maximum length of the connecting segment. Set it to zero and
the connecting segment will always be placed. If you set it nonzero but
close to zero, then the connecting segments will always be disabled. This
is the correct way to implement your request and I already had a prototype
showing this field in the UI.

Anyway, thanks for your effort. It gives me a motivation to finish the
configuration of the link_max_length UI.

Vojtech

On Sun, Nov 6, 2016 at 1:34 PM, Luca Béla Palkovics <
notifications@github.com> wrote:

I suppose the lines are shifted somehow like offset -= (layer_z) % spacing
(couldn't find where/how it's done..) and so it will need an extra line
sometimes..

Anyways adding 1 extra line fixes the problem. No idea if this has ugly

side effects..

You can view, comment on, or merge this pull request online at:

#18
Commit Summary

• add 1 extra infill line

File Changes

• M xs/src/libslic3r/Fill/FillRectilinear2.cpp
  https://github.com/prusa3d/Slic3r/pull/18/files#diff-0 (2)

Patch Links:

• https://github.com/prusa3d/Slic3r/pull/18.patch
• https://github.com/prusa3d/Slic3r/pull/18.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#18, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFj5Iw3wWVM1HvcaSi2XhOzwtR_My7WIks5q7clAgaJpZM4KqisW
.

[KoKuToru]

Thanks, nice to hear, but this pull request adds a missing line ..

The last line of the cubic infill is missing.. it's like this:

[ = permiter left
] = permiter right
| = infill line

actual:
z0: [|   |   |   |   |  ]
z1: [   |   |   |   |   ] <- most left line is outside now
z2: [  |   |   |   |    ] <- most right line is missing now

correct:
z0: [|   |   |   |   |  ]
z1: [   |   |   |   |   ]
z2: [  |   |   |   |   |]

it's missing 1 line because it gets shifted each layer..

[bubnikv]

oh, I see. It is a different issue from the transparent infill. I understand now.

[bubnikv]

Fixed, thanks for help.

e9e55e7