-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fan speed visualization in preview #2922
Conversation
This adds an option to preview fan speed as requested in issue prusa3d#1491. I needed this to verify that patch prusa3d#2781 generates correct output.
Checkout was in a messed up state when I uploaded this, so I have a to fix a few things and then I'll re-post it. |
Removed some default arguments for Metadata and GCodeMove constructors to prevent future errors.
Seems correct now. Sorry for the noise. I'm just learning Github's workflow (and am far from an expert on git in general). |
Makes M106 and M107 consistent if a P parameter is present.
This could still provide an incorrect visualization if the fan that's changed is not the current tool, but we later switch to it. However, that seems worth ignoring to keep the code simple for now.
This adds an option to preview fan speed as requested in issue prusa3d#1491. I needed this to verify that patch prusa3d#2781 generates correct output.
Removed some default arguments for Metadata and GCodeMove constructors to prevent future errors.
Makes M106 and M107 consistent if a P parameter is present.
This could still provide an incorrect visualization if the fan that's changed is not the current tool, but we later switch to it. However, that seems worth ignoring to keep the code simple for now.
…into view_fan_speed
thanks, merged into master. |
Thanks, glad it was useful. |
@jschuh, in the function |
Sorry, been busy with other things for the last few months. Answer inline...
Ah, that is a bug. The divisor should be 255 rather than 256, otherwise the percentage is off by a small fraction. However, the float promotion is implicit, so you don't need to change the type of the divisor (unless you just think it's clearer code). Unfortunately, I don't have a functional checkout right now, but it's a very simple patch if you want to submit it as a PR. Otherwise, I'll circle back to it once I get a chance. |
@jschuh, I just changed a 6 to a 5 and Prusa already committed it. Perhaps someone with extra super high color sensitivity could have been annoyed.... It is more about perfection. |
@rongith, that's awesome. Thanks for getting it fixed. |
This adds an option to preview fan speed as requested in issue #1491.
I needed this to verify that patch #2921 generates correct output.