-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add M486 to "Label Object" for Marlin firmware object canceling. #3086
Conversation
It would be great if the Prusa Firmware team could implement it as well. |
It lacks braces and the indexes shouldn't be created that way, but it's just an example, right? |
Just something I put together that more or less works. More robust ways of
index generation are welcome. I think the lack of braces was just a
continuation from the lack of braces in the original (and me spending more
time in python than C!).
…On Mon, Oct 21, 2019 at 10:43 AM Merill ***@***.***> wrote:
It lacks braces and the indexes shouldn't be created that way, but it's
just an example, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3086?email_source=notifications&email_token=AGYDYRR7OSSOBVFQEDDDIZLQPW5ZPA5CNFSM4JCUD5P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2SGHI#issuecomment-544547613>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGYDYRQZW7RFOWJ7YZCKKP3QPW5ZPANCNFSM4JCUD5PQ>
.
--
Paul Paukstelis, Ph.D
Associate Professor
University of Maryland
Chemistry & Biochemistry Dept.
Center for Biomolecular Structure & Organization
paukstel@umd.edu
301-405-9933
|
Fixed placement of M486 Tn (now just at the beginning). |
Thanks, we will likely integrate your code after the Prusa Mini release once we have the support for these new G-codes in the firmware. Your pull request in the current state will produce G-codes, that the older Marlins will not understand, thus they will emit warning over the serial line. Therefore we will need some way to suppress these codes on older firmwares. |
@paukstelis Is this PR still valid? I have seen that you have another branch for the post-processing script https://github.com/paukstelis/PrusaSlicer-M486/tree/offset_extrude |
My PR is now very old and probably needed a better approach anyway. I think the idea overall is still relevant. The post-processing is really just a stand-in for actual slicer modifications. |
This feature has already been implemented in PrusaSlicer, so I'm closing this PR. |
This PR adds the M486 gcode command to the "Label Object" output option. This will allow gcode output with this option to use the upcoming Marlin firmware option for cancelling individual objects during a multi-object print. Reference: MarlinFirmware/Marlin#15590