Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add M486 to "Label Object" for Marlin firmware object canceling. #3086

Closed
wants to merge 2 commits into from

Conversation

paukstelis
Copy link

This PR adds the M486 gcode command to the "Label Object" output option. This will allow gcode output with this option to use the upcoming Marlin firmware option for cancelling individual objects during a multi-object print. Reference: MarlinFirmware/Marlin#15590

@3d-gussner
Copy link

It would be great if the Prusa Firmware team could implement it as well.

@supermerill
Copy link
Contributor

It lacks braces and the indexes shouldn't be created that way, but it's just an example, right?

@paukstelis
Copy link
Author

paukstelis commented Oct 21, 2019 via email

@paukstelis
Copy link
Author

Fixed placement of M486 Tn (now just at the beginning).

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 5, 2019

Thanks, we will likely integrate your code after the Prusa Mini release once we have the support for these new G-codes in the firmware.

Your pull request in the current state will produce G-codes, that the older Marlins will not understand, thus they will emit warning over the serial line. Therefore we will need some way to suppress these codes on older firmwares.

@3d-gussner
Copy link

@paukstelis Is this PR still valid? I have seen that you have another branch for the post-processing script https://github.com/paukstelis/PrusaSlicer-M486/tree/offset_extrude

@paukstelis
Copy link
Author

My PR is now very old and probably needed a better approach anyway. I think the idea overall is still relevant. The post-processing is really just a stand-in for actual slicer modifications.

@hejllukas
Copy link
Collaborator

This feature has already been implemented in PrusaSlicer, so I'm closing this PR.

@hejllukas hejllukas closed this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants