Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream files required files for FlatHub #4039

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

xarbit
Copy link
Contributor

@xarbit xarbit commented Apr 10, 2020

These files should ideally be located upstream, it would be great to add them to the other resources.

Related issues:
flathub/flathub#1446
#3064
#1124

@tamasmeszaros
Copy link
Contributor

Hi @xarbit!

Many thanks for the Flatpak integration effort! Not too many commits ago I've placed a desktop file very similar to yours into src/platform/unix directory, please let us know if that suffices your needs.

There you should also find a desktop file for our GCode viewer application. That is essentially the prusa-slicer binary started up with the --gcodeviewer parameter and behaving like a completely different app. I don't know if Flatpaks support this kind of "one Flatpak -> multiple apps" behavior. AppImages certainly don't. BTW the icon for the GCode viewer is on the way, but missing from the repo yet.

As for the com.prusa3d.PrusaSlicer.metainfo.xml file, I have a feeling that it almost completely concerns the Flatpak creation thus it would belong to the repo where the Flatpak creation is encoded. I'm really not familiar with packaging Flatpaks so let me know if I got this wrong.

@xarbit
Copy link
Contributor Author

xarbit commented Oct 27, 2020

Hi @tamasmeszaros thanks for this, ill look in to the desktop file and give you feedback.
As for the com.prusa3d.PrusaSlicer.metainfo.xml file, FlatHub and FlatPak like this upstream and it is the AppStream data used in Linux App Stores such as GNOME Software and Co.

@xarbit
Copy link
Contributor Author

xarbit commented Oct 27, 2020

I think flatpack supports --gcodeviewer , ill check in to that .. thanks

@tamasmeszaros
Copy link
Contributor

Ok, I'll put it into master then. If I may, I would put it into a subdir like resources/data/flatpak so I will know what it is after a year passes by :v Would that be ok?

@xarbit
Copy link
Contributor Author

xarbit commented Oct 27, 2020

sure that works .. thanks :-)

@tamasmeszaros tamasmeszaros changed the base branch from master to tm_flatpak October 27, 2020 11:58
@tamasmeszaros tamasmeszaros merged commit 3ba6e17 into prusa3d:tm_flatpak Oct 27, 2020
@tamasmeszaros
Copy link
Contributor

So, I've discovered that the icon entry is different in your desktop file so I've put that into the flatpak subfolder as well. Please let me know how I could unite this desktop file with the one already in src/platform/unix if you have any idea. Thanks in advance.

@xarbit
Copy link
Contributor Author

xarbit commented Sep 2, 2021

@tamasmeszaros

by the way, I finally got around to implement --gcodeviewer in flatpak .. as desktop launcher and desktop action.

See alpha build here:
#1124 (comment)

@xarbit xarbit deleted the flatpak-for-linux-appstore branch September 2, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants