Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creality add superdetail and superdraft modes #5092

Closed
wants to merge 4 commits into from
Closed

Creality add superdetail and superdraft modes #5092

wants to merge 4 commits into from

Conversation

pmjdebruijn
Copy link
Contributor

Adds a 0.08mm superdetail mode
Adds a 0.28mm superdraft mode

Changes 0.15mm to 0.16mm, please do check the renamed_from line, given this isn't just a rename but also a minor functional change

while the alignment to magic numbers is somewhat of a debatable topic,
it may produce slightly nicer prints for some users,
centers 0.16 nicely between 0.12 and 0.20
and on the flip side, it has little disadvantages
@rtyr
Copy link
Collaborator

rtyr commented Nov 6, 2020

Merged. I only changed renamed_from = "0.15mm OPTIMAL @ENDER3; 0.15mm OPTIMAL @CREALITY" to renamed_from = "0.15mm OPTIMAL @ENDER3"; "0.15mm OPTIMAL @CREALITY" and bumped up the version. It is now also live at prusa3d/PrusaSlicer-settings.

@rtyr rtyr closed this Nov 6, 2020
@mathiasvr
Copy link
Contributor

I previously asked about why 0.15mm was chosen for the optimal preset, but why has it now been changed to 0.16mm?
I'm generally interested in the reasons for how and why these settings are chosen.

@pmjdebruijn
Copy link
Contributor Author

There is no one defining insight / reason.

As I stated earlier, I'm skeptical of the benefits of magic number alignment. However, there are many people who show improvements on their machines, where it is unclear what variables are at play. So any quality improvement may be rooted in magic number alignment obscuring another unresolved issue. That said, in the end I'm not entirely sure about this.

But on the flipside, there is no clear disadvantage to aligning to magic numbers either. So I choose to move 0.15 to 0.16, so it is aligned, and it may provide some minor quality improvement for some users.

It also has the the slight added benefit that 0.16 logically places nicely between 0.12 and 0.20, which in of itself isn't particular important, but it's nice nonetheless.

0.10 is now the only non-aligned preset, but supposedly a half step is almost as accurate as a full step, so that should be fine regardless, at least when presuming magic number alignment to be beneficial to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants