Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayed alerts not refreshing when a filter is edited #1869

Closed
koppchen opened this issue Jun 20, 2020 · 2 comments · Fixed by #1872
Closed

Displayed alerts not refreshing when a filter is edited #1869

koppchen opened this issue Jun 20, 2020 · 2 comments · Fixed by #1872

Comments

@koppchen
Copy link

When manually editing a filter in the top search bar, the alerts displayed aren't updated until the refresh triggered by the refresh interval happens.

Example, showing images for:

  1. The default filters on the demo site
  2. Editing one of the filters
  3. The spinning that occurs when the user presses enter after editing. This appears to last until the refresh interval, so it's more noticeable when a longer refresh interval (like 70s) is set.

20200620-karma_refresh_issue

This affects Karma v0.64. On the last Karma release, v0.63, editing a filter like this immediately refreshes the displayed alerts when the user presses enter.

This was tested locally and on the demo site (https://karma-demo.herokuapp.com/).

Tested on Chrome (83.0.4103.97) and Firefox (77.0.1)

Thank you!!!

@prymitive
Copy link
Owner

#1872 should fix that, thanks!

@github-actions
Copy link

github-actions bot commented Dec 1, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants