Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate silences created #1878

Closed
BenoitKnecht opened this issue Jun 23, 2020 · 7 comments · Fixed by #1880 or #1894
Closed

Duplicate silences created #1878

BenoitKnecht opened this issue Jun 23, 2020 · 7 comments · Fixed by #1880 or #1894
Assignees
Labels
bug Something isn't working

Comments

@BenoitKnecht
Copy link
Contributor

I'm not exactly sure when it started happening, but I think it began with version 0.64. When I create a silence in Karma using Silence this group, two identical silences end up being created.

It should be noted that I run two Alertmanagers in HA mode, and two instances of Karma behind HAproxy, running on the same VMs as each Alertmanager.

Here's the alertmanager section of karma.yml, which hasn't changed since 0.63 at least:

alertmanager:
  servers:
  - name: default
    uri: http://localhost:9093
    external_uri: https://alertmanager.example.com
    proxy: true
@prymitive prymitive self-assigned this Jun 23, 2020
@prymitive prymitive added the bug Something isn't working label Jun 23, 2020
@prymitive
Copy link
Owner

Looks like another request is being send when the modal is closed.

@prymitive
Copy link
Owner

Should be fixed now, will make a new release soon

@prymitive prymitive reopened this Jun 23, 2020
@prymitive
Copy link
Owner

Switching between tabs also triggers a new request (after it was submitted). Needs a better fix

@prymitive
Copy link
Owner

Need to move state handling so it doesn't get lost on tab switch. Will try to get it done in the next few days.

@prymitive
Copy link
Owner

Should be fixed for good now

@BenoitKnecht
Copy link
Contributor Author

I just upgraded to v0.66, and it works great, thanks!

@github-actions
Copy link

github-actions bot commented Dec 1, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
2 participants