Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): make warnings on the Help page more readable #1204

Merged
merged 1 commit into from
Nov 30, 2019
Merged

fix(ui): make warnings on the Help page more readable #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/Components/MainModal/Help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const QueryHelp = ({ title, operators, warning, children }) => (
))}
</div>
{warning ? (
<div className="my-1 alert alert-light">
<div className="my-1 alert alert-secondary">
<FontAwesomeIcon icon={faInfoCircle} className="mr-1" />
{warning}
</div>
Expand Down Expand Up @@ -240,7 +240,7 @@ const Help = ({ defaultIsOpen }) => (
<QueryHelp
title="Match alerts based on the ticket IDs detected in the silence comment"
operators={["=", "!=", "=~", "!~"]}
warning="This is supported only if ticket regexp are enabled and able to
warning="This is supported only if ticket regexp rules are enabled and able to
match ticket IDs in the silence comment."
>
<FilterExample example="@silence_ticket=PROJECT-123">
Expand Down
6 changes: 3 additions & 3 deletions ui/src/Components/MainModal/__snapshots__/Help.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ exports[`<Help /> matches snapshot 1`] = `
!~
</kbd>
</div>
<div class=\\"my-1 alert alert-light\\">
<div class=\\"my-1 alert alert-secondary\\">
<svg aria-hidden=\\"true\\"
focusable=\\"false\\"
data-prefix=\\"fas\\"
Expand All @@ -700,7 +700,7 @@ exports[`<Help /> matches snapshot 1`] = `
>
</path>
</svg>
This is supported only if ticket regexp are enabled and able to match ticket IDs in the silence comment.
This is supported only if ticket regexp rules are enabled and able to match ticket IDs in the silence comment.
</div>
<div>
Examples:
Expand Down Expand Up @@ -760,7 +760,7 @@ exports[`<Help /> matches snapshot 1`] = `
=
</kbd>
</div>
<div class=\\"my-1 alert alert-light\\">
<div class=\\"my-1 alert alert-secondary\\">
<svg aria-hidden=\\"true\\"
focusable=\\"false\\"
data-prefix=\\"fas\\"
Expand Down